Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: rename jaeger-standalone to jaeger-all-in-one #932

Closed
yurishkuro opened this issue Jul 12, 2018 · 7 comments
Closed

Proposal: rename jaeger-standalone to jaeger-all-in-one #932

yurishkuro opened this issue Jul 12, 2018 · 7 comments
Assignees

Comments

@yurishkuro
Copy link
Member

The docker image is labeled all-in-one but we call the executable jaeger-standalone and that's how it is included in the binary distributions. I propose we change the executable to be called all-in-one as well.

We can probably even rename the source directory to cmd/all-in-one, since the package name there is main anyway.

@black-adder
Copy link
Contributor

let's keep releasing jaeger-standalone until we release 2.0? I'm pretty sure there are people who are directly using all-in-one.

@yurishkuro
Copy link
Member Author

everyone should be using versioned releases, so if we rename it in 1.7 it's not going to break anyone unless people explicitly upgrade.

@yurishkuro
Copy link
Member Author

everyone should be using versioned releases

Specifically, we're talking about renaming the binary, which you can ONLY download from a concrete version (unlike Docker images where we, mistakenly, published tag "1")

@jpkrohling
Copy link
Contributor

Funny, I thought about opening an issue some time ago about this, but in the other direction: instead of "all-in-one", standardizing on "standalone".

@yurishkuro
Copy link
Member Author

I think picking one name is more important than which name, but I think all-in-one is a bit more accurate and, more importantly, backwards compatible - there are many blog posts that refer to it already.

@jpkrohling
Copy link
Contributor

For the record, I have nothing against all-in-one. I just find it easier to type "standalone" instead :-)

@Dieterbe
Copy link
Contributor

Dieterbe commented Aug 9, 2018

👍

@ghost ghost assigned pavolloffay Sep 18, 2018
@ghost ghost added the review label Sep 18, 2018
@ghost ghost removed the review label Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants