Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It seems that you did not sample 7 points on the helix for training as described in the paper, is it because it has not been completed yet? #5

Open
qhdqhd opened this issue May 12, 2023 · 1 comment
Open

It seems that you did not sample 7 points on the helix for training as described in the paper, is it because it has not been completed yet? #5

qhdqhd opened this issue May 12, 2023 · 1 comment

Comments

@qhdqhd
Copy link

qhdqhd commented May 12, 2023

It seems that you did not sample 7 points on the helix for training as described in the paper, is it because it has not been completed yet?
@jake-austin
Copy link
Owner

The paper is interested in having multisamples sampled from an isotropic gaussian with mean equal to the point we're interested in, and variance as specified in the paper, so I just sample according to that gaussian directly instead of bothering with the helix which they used for speedup purposes (which I'm not certain gets us a ton of speedup tbh since we're just sampling from a gaussian which I don't believe is that expensive, tho I may be wrong on that one)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@qhdqhd @jake-austin