-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Storing Secrets #170
Comments
Hey @TonyBrobston, thanks for the great suggestion. I pushed a new beta build to include this ability. I modeled it similar to how Home Assistant does it. Let me know what you think! Create a mqtt:
host: localhost
username: mqtt
password: !secret mqtt_password
detectors:
compreface:
url: localhost:8000
key: !secret compreface_key The mqtt_password: <password>
compreface_key: <api-key> |
Awesome, I'll give that a shot and report back. I assume there is a beta docker image tag? I'll take a look when I have time. Thanks! |
|
Sounds good. I'm currently running on a server with an AMD Ryzen Threadripper, so beta should be good. |
# [1.7.0](v1.6.0...v1.7.0) (2021-11-27) ### Bug Fixes * better support of jpg images for thumbnails/box ([#156](#156)) ([04e7d83](04e7d83)) * lowercase camera name in mqtt topics ([#163](#163)) ([57e605b](57e605b)) * optional chaining for frigate url ([68a9032](68a9032)) * use lower compreface det_prob_threshold for /recognize/test ([#136](#136)) ([6a0c435](6a0c435)) ### Features * ability to change mqtt client_id ([#168](#168)) ([98d7f2a](98d7f2a)) * **api:** validate config with jsonschema ([ad23c7b](ad23c7b)) * edit secrets.yml from ui ([963cacd](963cacd)) * secrets.yml support ([#170](#170)) ([53b11c8](53b11c8)) * support ui base path ([#166](#166)) ([b1d06aa](b1d06aa))
This was included in the latest release |
I finally got around to using this, it works great! I was able to back everything up to a github repo and keep my secrets out! |
Awesome! So happy to hear it's working for you. |
My apologies if this is covered somewhere and I missed it. Is there a pattern for dealing with secrets, passwords, things you don't want directly in your config?
I see that Frigate uses a pattern where you can create environment variables prefixed with
FRIGATE_
and then reference them in yaml by wrapping the environment variable in curly braces{FRIGATE_MQTT_PASSWORD}
, does something like this exist in Double Take?If Double Take does not have this yet, it seems like using the same pattern as Frigate could make this straight forward for users?
My main issue is that my mqtt-broker has a username/password and I would like to keep my mqtt password out of my config file; often times I leave these config files open source and reference them.
Thanks for the work on this repo, it is a much needed tool and I look forward to working with it more!
The text was updated successfully, but these errors were encountered: