Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for :unless, passing attributes, parametrizing :event_class_name, and cleanup #11

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

onedesign
Copy link

Hello!

We recently introduced timeline_fu into a project, and made some changes which we think would be helpful for everyone.

This fork was based off szajbus/timeline_fu and incorporates their features, which came in handy.

It also adds support for specifying :event_class_name, so TimelineEvent is not hardcoded, as well as specifying more than one event class. This is helpful in situations where tracking for events by Comment should be handled by CommentEvent and be separate from Post, which is handled by PostEvent, for example. We also found it helpful to specify :event_class_name => ["CommentEvent", "UserEvent"], thus being able to easily build an audit log for a particular Comment, as well as an entire activity log for a User.

Finally, we cleaned up the gemspec and added the gem’s dependencies to it, introduced bundler, and appraisal, so the gem is now tested against the latest stable version of ActiveRecord 2.3.x, 3.0.x, and 3.1.x (all tests currently pass, of course)

We hope you approve and thanks for starting timeline_fu!

Cheers,

The folks at One Design Company

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants