Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server List Is Not Accessible With Screen Reader on Mac #490

Open
chigkim opened this issue Aug 3, 2020 · 12 comments
Open

Server List Is Not Accessible With Screen Reader on Mac #490

chigkim opened this issue Aug 3, 2020 · 12 comments
Labels
bug Something isn't working

Comments

@chigkim
Copy link
Contributor

chigkim commented Aug 3, 2020

Describe the bug

Server List Is Not Accessible With Screen Reader on Mac

To Reproduce

  1. Open server list to join.
  2. Turn on VoiceOver with command+f5 (or command+triple click power on newer mac with with touch bar)
  3. Try navigating the list with tab and arrows
    None of the QTreeWidgetItems are not announced as being selected.
    However, if you move the mouse cursor to one of the item and press control+option+f5, you'll hear what's under the mouse.
    It seems like QTreeWidgetItems are accessible, but they don't appear as children of QTreeWidget to accessibility API.

Expected behavior

QTreeWidgetItems should be announced

Screenshots

/

Operating system

macOS

Version of Jamulus

?

Additional context

Probably fixed here: https://chigkim.github.io/jamulus/

@corrados corrados added the bug Something isn't working label Aug 3, 2020
@corrados
Copy link
Contributor

corrados commented Aug 9, 2020

However, if you move the mouse cursor to one of the item and press control+option+f5, you'll hear what's under the mouse.

I have tried this but it does not work on my Mac. Maybe it is an issue of my old MacOS.

It seems like QTreeWidgetItems are accessible, but they don't appear as children of QTreeWidget to accessibility API.

That sounds to me like a but in Qt since the QTreeWidgetItems are always children of QTreeWidget, right? Or is there a possibility to add QTreeWidgetItems in a QTreeWidget if they are not children?

@chigkim
Copy link
Contributor Author

chigkim commented Aug 9, 2020 via email

@corrados
Copy link
Contributor

I just tried it out with the screen reader which is built-in the Windows 10 operating system. That screen reader can read all list items without any problem. You can even let it read the connected musicians names.

So I assume that we have an issue which is Qt and Mac related. I don't think I can fix anything in the Jamulus software to get it working.

I see that you have implemented a workaround. But unfortunately, this code I cannot use in the official Jamulus version.

@chigkim
Copy link
Contributor Author

chigkim commented Aug 11, 2020 via email

@ann0see
Copy link
Member

ann0see commented Jan 26, 2022

@chigkim once we're moving to Qt6 (https://github.com/hoffie/jamulus/tree/Qt6-hoffie-cleanup) could you please test if anything gets better?

@chigkim
Copy link
Contributor Author

chigkim commented Jan 27, 2022 via email

@ann0see
Copy link
Member

ann0see commented Jan 27, 2022

You should be able to have a look at the PR‘s by @hoffie tomorrow/at the weekend

@hoffie hoffie mentioned this issue Jan 27, 2022
11 tasks
@hoffie
Copy link
Member

hoffie commented Jan 27, 2022

Sure, please ping me when the migration completes.

Hard to tell when the full switch completes, but you can already try builds from PR #2300 here:
All binaries (or: Direct link for Mac). Only Windows (64bit) and Mac (non-legacy) have changed. If you are using any other platform, then these binaries are unlikely to improve things for you yet.

Note: This is completely untested. Please report back if you see any breakage or -- hopefully -- improvements with regards to screen reader compatibility.

@chigkim
Copy link
Contributor Author

chigkim commented Feb 19, 2022

Unfortunately the server list is still broken.
I could be wrong, but I don't think qt6 addressed QTreeWidget and QTreeWidgetItems for Mac.

@ann0see
Copy link
Member

ann0see commented Feb 19, 2022

That’s not good. Is it a known Qt bug or can Jamulus work around it - in a compatible way of course?

@ann0see
Copy link
Member

ann0see commented Feb 19, 2022

If it’s a Qt Bug, maybe an issue can be raised on their side

@ann0see
Copy link
Member

ann0see commented Apr 22, 2022

Hi, Sorry for the maintenance noise here. I’m just into triaging issues. I've just updated the issue description to fit into the template. Hopefully some day this issue will be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Triage
Development

No branches or pull requests

4 participants