Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when using the JACK backend and quickly reconfiguring #543

Closed
corrados opened this issue Aug 26, 2020 · 4 comments
Closed

Crash when using the JACK backend and quickly reconfiguring #543

corrados opened this issue Aug 26, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@corrados
Copy link
Contributor

It is reported that Jamulus crashes if a quick reconfiguring is done. See #529

@corrados corrados added bug Something isn't working development in progress labels Aug 26, 2020
@corrados
Copy link
Contributor Author

@hselasky Can you please write how to reproduce the crash? What did you do exactly before it crashed? Do you mean with "quick reconfiguring" a settings change in Jamulus like, e.g., from Mono to Stereo?

@hselasky
Copy link
Contributor

@corrados : Please use the attached patch to provoke the error.

Without my patch you will get this print: "Sound was processing while init"
With my patch this print is gone, and everything is fine.
The crash results from accessing the data buffers while they are being reconfigured, but is not so easy to reproduce.

--HPS
provoke.txt

@corrados
Copy link
Contributor Author

Now I think I know what's causing the crash. Any yes, a mutex as you implemented will solve the issue. Thanks for your code. I'll merge it soon.

@corrados
Copy link
Contributor Author

The code is merged now -> closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants