-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question for the dataset.py #7
Comments
Hi halbielee, Thank you for your interest in our work! I am happy to help you. Indeed, you are absolutely correct that it appears to be my mistake during refactoring. The code for the result from the paper did not have this bug (only during refactoring). However, we did try this version before and it makes very small difference; in fact, many contrastive learning papers choose this way (contrasting between x <-> T(x) instead of T1(x) <-> T2(x)). I fixed the code just now. Thank you! Jang Hyun Cho |
Hi halbielee, Here is the training log of PiCIE with the updated code. ACC - All: 51.5297 Best, Jang Hyun Cho |
Thank you for the quick and kind reply :) |
Hello, thanks for sharing your excellent work!
I have a question about your code, especially coco_train_dataset.py.
PiCIE/data/coco_train_dataset.py
Lines 97 to 106 in 62d2748
When applying the transform_tensor function to the image, it applies to the variable image not image1.
Is there any issue for this?
Thanks!
The text was updated successfully, but these errors were encountered: