Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

computing phone method availability is done in different places using different criteria #665

Closed
jpaniagualaconich opened this issue Sep 10, 2023 · 0 comments · Fixed by #666
Closed

computing phone method availability is done in different places using different criteria #665

jpaniagualaconich opened this issue Sep 10, 2023 · 0 comments · Fixed by #666

Comments

@jpaniagualaconich
Copy link
Contributor

Expected Behavior

There should be a single way to check which phone methods are available.

Current Behavior

In some places availability is determined by the presence of 'two_factor.plugins.phonenumber' in INSTALLED_APPS.
Other places take into account also / only values for settings.TWO_FACTOR_CALL_GATEWAY and settings.TWO_FACTOR_SMS_GATEWAY.

Possible Solution

We already have a method registry, which should be the only source of truth.
jpaniagualaconich added a commit to jpaniagualaconich/django-two-factor-auth that referenced this issue Sep 10, 2023
@jpaniagualaconich
use registry to determine available phone methods (fixes jazzband#665)
529388d
@jpaniagualaconich jpaniagualaconich mentioned this issue Sep 10, 2023
Merged
8 tasks
jpaniagualaconich added a commit to jpaniagualaconich/django-two-factor-auth that referenced this issue Sep 10, 2023
@jpaniagualaconich
use registry to determine available phone methods (fixes jazzband#665)
4241847
jpaniagualaconich added a commit to jpaniagualaconich/django-two-factor-auth that referenced this issue Sep 10, 2023
@jpaniagualaconich
use registry to determine available phone methods (fixes jazzband#665)
4e3748d
jpaniagualaconich added a commit to jpaniagualaconich/django-two-factor-auth that referenced this issue Sep 10, 2023
@jpaniagualaconich
use registry to determine available phone methods (fixes jazzband#665)
261e8ce
jpaniagualaconich added a commit to jpaniagualaconich/django-two-factor-auth that referenced this issue Sep 10, 2023
@jpaniagualaconich
use registry to determine available phone methods (fixes jazzband#665)
ac7d8d4
jpaniagualaconich added a commit to jpaniagualaconich/django-two-factor-auth that referenced this issue Sep 10, 2023
@jpaniagualaconich
use registry to determine available phone methods (fixes jazzband#665)
916e819
jpaniagualaconich added a commit to jpaniagualaconich/django-two-factor-auth that referenced this issue Sep 10, 2023
@jpaniagualaconich
use registry to determine available phone methods (fixes jazzband#665)
e210f44
jpaniagualaconich added a commit to jpaniagualaconich/django-two-factor-auth that referenced this issue Sep 10, 2023
@jpaniagualaconich
use registry to determine available phone methods (fixes jazzband#665)
7954670
jpaniagualaconich added a commit to jpaniagualaconich/django-two-factor-auth that referenced this issue Sep 11, 2023
@jpaniagualaconich
use registry to determine available phone methods (fixes jazzband#665)
4983f63
jpaniagualaconich added a commit to jpaniagualaconich/django-two-factor-auth that referenced this issue Sep 11, 2023
@jpaniagualaconich
use registry to determine available phone methods (fixes jazzband#665)
20dfb4f
jpaniagualaconich added a commit to jpaniagualaconich/django-two-factor-auth that referenced this issue Feb 3, 2024
@jpaniagualaconich
use registry to determine available phone methods (fixes jazzband#665)
c70ebfc
claudep pushed a commit that referenced this issue Feb 3, 2024
@jpaniagualaconich @claudep
use registry to determine available phone methods (fixes #665)
ae795df
claudep pushed a commit that referenced this issue Feb 3, 2024
@jpaniagualaconich @claudep
use registry to determine available phone methods (fixes #665)
2ae4ce7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor phone method availability checks jpaniagualaconich/django-two-factor-auth
1 participant
@jpaniagualaconich