Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move registry.get_methods() call to separate method, to all… #535

Merged
merged 1 commit into from
Sep 17, 2022

Conversation

last-partizan
Copy link
Contributor

…ow customization

Refs #533

Description

This PR replaces direct call to registry.get_methods() with self.get_available_methods() in SetupView, to allow customization if methods available for setup depending on user.

How Has This Been Tested?

This does not introduce any new behaviour, already covered by normal unit tests.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Contributor

@claudep claudep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@codecov
Copy link

codecov bot commented Sep 4, 2022

Codecov Report

Merging #535 (59a01e8) into master (f427f59) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #535   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files          62       62           
  Lines        2734     2736    +2     
  Branches      284      284           
=======================================
+ Hits         2687     2689    +2     
  Misses         28       28           
  Partials       19       19           
Impacted Files Coverage Δ
two_factor/views/core.py 97.18% <100.00%> (+0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants