Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relax pydantic dependency (fixes #634) #650

Closed

Conversation

jpaniagualaconich
Copy link
Contributor

Description

ValidationError is now imported from the "official" place.

Motivation and Context

Newer versions of py_webauthn also work with pydantic v2. We make use of the ValidationError symbol which fortunately is in the same path for both v1 and v2.

Fixes #634

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #650 (f9264f8) into master (08ef1b8) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #650   +/-   ##
=======================================
  Coverage   95.38%   95.38%           
=======================================
  Files          75       75           
  Lines        3252     3252           
  Branches      372      372           
=======================================
  Hits         3102     3102           
  Misses        119      119           
  Partials       31       31           
Files Changed Coverage Δ
two_factor/plugins/webauthn/forms.py 83.54% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jpaniagualaconich jpaniagualaconich deleted the pydanticv2-pr branch September 10, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please relax pydantic dependency
1 participant