Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc suggests pre-commit hook should run with requirements.txt #1615

Closed
dycw opened this issue Apr 17, 2022 · 2 comments · Fixed by #1847
Closed

Doc suggests pre-commit hook should run with requirements.txt #1615

dycw opened this issue Apr 17, 2022 · 2 comments · Fixed by #1847
Labels
good first issue A good item for first time contributors to work on pre-commit Related to pre-commit hook

Comments

@dycw
Copy link
Contributor

dycw commented Apr 17, 2022

The documentation suggests the pre-commit hook:

         - id: pip-compile
            name: pip-compile requirements.txt
            args: [requirements.txt]
            files: ^requirements\.(in|txt)$

however this is incorrect — it should be requirements.in which is passed in.

@atugushev atugushev added the pre-commit Related to pre-commit hook label Apr 24, 2022
@atugushev atugushev added the good first issue A good item for first time contributors to work on label Jun 7, 2022
@atugushev
Copy link
Member

@dycw thanks for noticing! This looks like a candidate for a "good first issue".

@dycw
Copy link
Contributor Author

dycw commented Jun 7, 2022

Hi @atugushev , I've opened a PR; please review at your convenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue A good item for first time contributors to work on pre-commit Related to pre-commit hook
Projects
None yet
2 participants