Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin setuptools in test_allow_unsafe_option #988

Closed
webknjaz opened this issue Nov 16, 2019 · 4 comments · Fixed by #1016
Closed

Pin setuptools in test_allow_unsafe_option #988

webknjaz opened this issue Nov 16, 2019 · 4 comments · Fixed by #1016
Assignees
Labels
refactor Refactoring code tests Testing and related things

Comments

@webknjaz
Copy link
Member

FTR, would be nice to pin setuptools here as well, but it would take to rewrite the test.

Originally posted by @atugushev in #975

@atugushev atugushev added refactor Refactoring code tests Testing and related things labels Nov 16, 2019
@atugushev
Copy link
Member

atugushev commented Nov 16, 2019

Better to be fixed after #990.

@atugushev
Copy link
Member

@hramezani would you be interested in this issue as a followup #990?

Since test_allow_unsafe_option has been already refactored we can pin now the package (small-fake-a) in parameters and make test_allow_unsafe_option test more assertive:

...
[("--allow-unsafe", "\nsmall-fake-a==0.1"), (None, "\n# small-fake-a")],
...
assert expected in out.stderr.splitlines()

Also, would be nice to fix test_local_url_package the same way.

@hramezani
Copy link
Member

@atugushev yes, Just assign it to me.

@atugushev
Copy link
Member

@hramezani, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring code tests Testing and related things
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants