Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New color themes? #310

Open
Bikes4Fun opened this issue Sep 23, 2024 · 5 comments · May be fixed by #312
Open

New color themes? #310

Bikes4Fun opened this issue Sep 23, 2024 · 5 comments · May be fixed by #312

Comments

@Bikes4Fun
Copy link

This request adds new color themes to the ColorTable class in PrettyTable. This provides users with built in options for customizing the appearance of their tables.

Changes made:

  • Added 8 new themes to the Themes class in colortable.py:
    • FOREST
    • SUNSET
    • OCEAN_DEEP
    • LAVENDER
    • MONOCHROME
    • NEON
    • EARTH
    • PASTEL

Benefits:

  1. Increased customization options for users
  2. More variety in color schemes to suit different preferences and use cases
  3. Includes themes with both basic and extended color palettes for compatibility with various terminal environments

Testing:

  • Tested all new themes in multiple terminal environments to ensure compatibility
  • Verified that existing functionality remains unchanged

Usage example:
Screenshot 2024-09-22 at 11 17 24 PM
Screenshot 2024-09-22 at 11 17 33 PM
Screenshot 2024-09-22 at 11 17 41 PM

@hugovk
Copy link
Member

hugovk commented Sep 23, 2024

Looks good, would you like to open a PR?

@Bikes4Fun
Copy link
Author

Yes please :)

@Bikes4Fun
Copy link
Author

Hi, I've worked on team projects but I have not contributed to open source public projects yet. I have this working locally but in the past I've had a button to branch from an issue. Could you possibly direct me to that system for a managed project like this?

@hugovk
Copy link
Member

hugovk commented Sep 25, 2024

Hi, here's some info on how to contribute to a project on GitHub, does this help?

https://docs.github.com/en/get-started/exploring-projects-on-github/contributing-to-a-project

@Bikes4Fun
Copy link
Author

Oh yes. That is a little different. Thank you so much.

@hugovk hugovk linked a pull request Oct 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants