Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

public String constants in MavenClasspath already exist #72

Open
simonjenga opened this issue Jan 8, 2016 · 2 comments
Open

public String constants in MavenClasspath already exist #72

simonjenga opened this issue Jan 8, 2016 · 2 comments

Comments

@simonjenga
Copy link
Contributor

public String constants in com.jcabi.aether.MavenClasspath already exist and are defined in the interface org.apache.maven.artifact.Artifact

https://github.com/apache/maven/blob/master/maven-artifact/src/main/java/org/apache/maven/artifact/Artifact.java

https://maven.apache.org/ref/3-LATEST/maven-artifact/apidocs/index.html?overview-summary.html

Let's use those defined in the interface class and delete those in our implementation so as to avoid
duplication.
@dmarkov
Copy link

dmarkov commented Jan 11, 2016

@yegor256 please take a look at it and dispatch (see par.21)

@simonjenga
Copy link
Contributor Author

@dmarkov I am still waiting for a response on this issue... 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simonjenga @dmarkov