Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the Manifests class to an immutable #38

Open
westonal opened this issue Jun 27, 2016 · 3 comments
Open

Refactor the Manifests class to an immutable #38

westonal opened this issue Jun 27, 2016 · 3 comments

Comments

@westonal
Copy link

westonal commented Jun 27, 2016

In line with objects should be immutable, refactor the Manifests class to be an immutable.

Acceptance criteria:

  • Manifests is immutable, that is no exposed methods will change its internal state
  • Manifests no longer implements Map<String, String>, though it should keep get method
  • Manifests provides a mutable map copy from a method: Map<string, string> asMap() providing an upgrade route for anyone relying on its previous implementation of Map
  • Remove @SuppressWarnings("PMD.TooManyMethods") from the class, as most of the old Map methods will be gone
@dmarkov
Copy link

dmarkov commented Jul 1, 2016

@yegor256 please pay attention to this issue (par.21)

@yegor256 yegor256 added the bug label Jul 1, 2016
@dmarkov
Copy link

dmarkov commented Jul 4, 2016

@westonized thanks for this report, I added 15 mins to your account, in transaction AP-92K25680T0309344B

@proshin-roman
Copy link
Contributor

@westonal @dmarkov the issue has been fixed in a pull request #43. Please check if the ticket can be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants