Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Higher Brightness Bug #4

Open
TP555 opened this issue Apr 6, 2019 · 2 comments
Open

Higher Brightness Bug #4

TP555 opened this issue Apr 6, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@TP555
Copy link

TP555 commented Apr 6, 2019

Hi

Higher Brightness Settings , and the Neuron Textures or some addon Textures Vanisch , and shows just the old one's Classic Textures !

The Effects from the JKGFX2019b Mod , still show up !

@SirYodaJedi
Copy link
Contributor

I'm not quite sure what this issue is trying to say, but the main menus do appear washed out compared to DgVoodoo. (I don't have a screenshot of what it looks like with jkgfxmod right now.)

@jdmclark
Copy link
Owner

Hi

Higher Brightness Settings , and the Neuron Textures or some addon Textures Vanisch , and shows just the old one's Classic Textures !

The Effects from the JKGFX2019b Mod , still show up !

The root cause of this issue is the method JK uses to implement the brightness slider. JK implements brightness by modifying the textures in memory to appear brighter. Fixing this issue would therefore require the following work:

  • Reverse engineer the algorithm JK uses to adjust the textures. The obvious candidates are a colormap light level bias (easy) or something more cryptic implemented in code (hard).
  • Use the reverse-engineered algorithm in compile to calculate hashes for the replaced textures at all brightness levels. The reverse engineered algorithm must be bit accurate, otherwise these hashes will not be correct.
  • Add brightness levels to the material map, so renderer can brighten the texture to match what the user expects.

Given the time involved and the meager utility of the brightness slider, I'm probably not going to implement this any time soon. I'm more inclined to fix this in doc and triage down (or just close wontfix).

@jdmclark jdmclark added the bug Something isn't working label May 15, 2019
jdmclark pushed a commit that referenced this issue Mar 23, 2020
jdmclark added a commit that referenced this issue Mar 26, 2020
Created a 'common problems' section in the main readme.

Moved doc fix for #4 to this section (brightness must be 0).

Added note about needing to start a new game after installing mods.

Fixes #40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants