From 585aaf0e8ccf51900c758bd6b533c7b946d68b0b Mon Sep 17 00:00:00 2001 From: "Joseph D. Gaeddert" Date: Sun, 14 Apr 2024 09:01:05 -0400 Subject: [PATCH 1/8] github: testing uploading with github action --- .github/workflows/coverage.yml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index 14258ec71..46447fb45 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -45,5 +45,8 @@ jobs: - name: make coverage run: make -j 2 coverage - - name: upload report - run: bash <(curl -s https://codecov.io/bash) + - name: upload report to codecov with github action + uses: codecov/codecov-action@v4.2.0 + env: + CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} + From e20809b31fcdad308a7b48282dcc5e892a844472 Mon Sep 17 00:00:00 2001 From: "Joseph D. Gaeddert" Date: Sun, 14 Apr 2024 09:02:24 -0400 Subject: [PATCH 2/8] github: enabling coverage workflow on coverage-dev branch --- .github/workflows/coverage.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index 46447fb45..e6df2e358 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -6,6 +6,7 @@ on: push: branches: - master + - coverage-dev jobs: standard: From 1e7fccf6e1ff2a14995bce430310708bf8d4a66d Mon Sep 17 00:00:00 2001 From: "Joseph D. Gaeddert" Date: Sun, 14 Apr 2024 09:19:52 -0400 Subject: [PATCH 3/8] github: adding verbose flag to coverage upload testing --- .github/workflows/coverage.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index e6df2e358..ffb00040c 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -48,6 +48,8 @@ jobs: - name: upload report to codecov with github action uses: codecov/codecov-action@v4.2.0 + with: + verbose: true env: CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} From bb2826d53ba38d63047748b5a756447b6549a2b0 Mon Sep 17 00:00:00 2001 From: "Joseph D. Gaeddert" Date: Sun, 14 Apr 2024 09:30:28 -0400 Subject: [PATCH 4/8] github: moving token to 'with' instead of 'env' --- .github/workflows/coverage.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index ffb00040c..9e6d90f85 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -49,7 +49,5 @@ jobs: - name: upload report to codecov with github action uses: codecov/codecov-action@v4.2.0 with: - verbose: true - env: CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} From 9994d32ac8f3b32b540419ae920c70aaf78ec656 Mon Sep 17 00:00:00 2001 From: "Joseph D. Gaeddert" Date: Sun, 14 Apr 2024 09:33:28 -0400 Subject: [PATCH 5/8] github: fixing syntax for specifying secret token, adding fail on error --- .github/workflows/coverage.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index 9e6d90f85..9e94d2105 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -49,5 +49,7 @@ jobs: - name: upload report to codecov with github action uses: codecov/codecov-action@v4.2.0 with: - CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} + fail_ci_if_error: true + token: ${{ secrets.CODECOV_TOKEN }} + From 25db8f315e355349297dc912a3047ebbfdedf391 Mon Sep 17 00:00:00 2001 From: "Joseph D. Gaeddert" Date: Sun, 14 Apr 2024 09:37:31 -0400 Subject: [PATCH 6/8] github: downgrading codecov action to v4 --- .github/workflows/coverage.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index 9e94d2105..6809dcd0b 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -47,7 +47,7 @@ jobs: run: make -j 2 coverage - name: upload report to codecov with github action - uses: codecov/codecov-action@v4.2.0 + uses: codecov/codecov-action@v4 with: fail_ci_if_error: true token: ${{ secrets.CODECOV_TOKEN }} From 486eb8e5b5f8fee6f4394c16aaa4ecfb93e2ab18 Mon Sep 17 00:00:00 2001 From: "Joseph D. Gaeddert" Date: Sun, 14 Apr 2024 09:53:03 -0400 Subject: [PATCH 7/8] github: testing token key in workflow --- .github/workflows/coverage.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index 6809dcd0b..6265a2294 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -50,6 +50,7 @@ jobs: uses: codecov/codecov-action@v4 with: fail_ci_if_error: true - token: ${{ secrets.CODECOV_TOKEN }} + verbose: true + token: "my-secret-token" #${{ secrets.CODECOV_TOKEN }} From c4a568557de953758d36858e8384db2b341f4649 Mon Sep 17 00:00:00 2001 From: "Joseph D. Gaeddert" Date: Sun, 14 Apr 2024 10:08:19 -0400 Subject: [PATCH 8/8] github: trying to use proper token; not sure why this is not working --- .github/workflows/coverage.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index 6265a2294..a5ea16160 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -51,6 +51,4 @@ jobs: with: fail_ci_if_error: true verbose: true - token: "my-secret-token" #${{ secrets.CODECOV_TOKEN }} - - + token: ${{ secrets.CODECOV_TOKEN }}