Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qs1dsearch: free object in _destroy #333

Merged
merged 1 commit into from
Sep 10, 2023

Conversation

nowls
Copy link
Contributor

@nowls nowls commented Sep 7, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (8bf87b6) 85.10% compared to head (9653f64) 85.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #333      +/-   ##
==========================================
- Coverage   85.10%   85.09%   -0.01%     
==========================================
  Files         367      367              
  Lines       27280    27281       +1     
==========================================
- Hits        23216    23215       -1     
- Misses       4064     4066       +2     
Files Changed Coverage Δ
src/optim/src/qs1dsearch.c 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@jgaeddert jgaeddert merged commit 000f96c into jgaeddert:master Sep 10, 2023
4 of 5 checks passed
@jgaeddert
Copy link
Owner

Thanks for this! I have a pipeline (for gitlab.com) that runs valgrind to find memory leaks like the one you found; however it was taking way too long to execute so I effectively removed it. I should probably reinstate at least some version of it, and on GitHub.com.

@jgaeddert
Copy link
Owner

jgaeddert commented Sep 10, 2023

also #ProgrammingInC

@nowls nowls deleted the qs1dsearch-free branch February 17, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants