forked from binary-com/deriv-app
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Likhith/76945/migrate wizard component to ts #36
Merged
jim-deriv
merged 7 commits into
jim-deriv:Jim/77633/components-shared-ts-migration-parent-2
from
likhith-deriv:likhith/76945/migrate-wizard-component-to-ts
Oct 6, 2022
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
777b68c
refactor: :art: migrate wizard component to TS
likhith-deriv 692d0ef
refactor: :recycle: incorporated review comments
likhith-deriv 7d58b33
fix: :recycle: incorporated review comments
likhith-deriv fbc77b6
fix: :recycle: added a check
likhith-deriv 4f7f304
refactor: :recycle: incorporated review comments
likhith-deriv 6fe2889
Merge remote-tracking branch 'jim/Jim/77633/components-shared-ts-migr…
likhith-deriv 4f78f84
refactor: :recycle: changed function call
likhith-deriv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
2 changes: 1 addition & 1 deletion
2
...omponents/src/components/wizard/index.tsx → ...components/src/components/wizard/index.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
import Wizard from './wizard.jsx'; | ||
import Wizard from './wizard'; | ||
import './wizard.scss'; | ||
|
||
export default Wizard; |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
import React from 'react'; | ||
import classNames from 'classnames'; | ||
|
||
const Step = ({ children = [], className }: React.PropsWithChildren<{ className?: string }>) => ( | ||
<div className={classNames('wizard__main-step', className)}>{children}</div> | ||
); | ||
|
||
export default Step; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since you initialized
nav
withnull
, you can make it optional here.