Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asciidoctor-pdf convergence #3

Closed
habamax opened this issue Dec 17, 2017 · 3 comments
Closed

asciidoctor-pdf convergence #3

habamax opened this issue Dec 17, 2017 · 3 comments

Comments

@habamax
Copy link

habamax commented Dec 17, 2017

Is it possible to alias or rename rouge-theme to rouge-style?

Currently asciidoctor-pdf has the rouge highlighter and it uses rouge-style attribute:

asciidoctor/asciidoctor-pdf#876

I think it would be good to have the same attribute name to avoid:

:source-highlighter: rouge
:rouge-theme: github
:rouge-style: github

In a document that is intended to produce html and pdf.

@jirutka
Copy link
Owner

jirutka commented Dec 17, 2017

That’s a good point! However, rouge-style would be inconsistent with Asciidoctor; there is highlightjs-theme, prettify-theme, and pygments-style. That’s 2:1, moreover Pygments is obsolete.

I’d personally prefer rouge-style, but I wanted to be consistent with Asciidoctor… 😞

I can add pygments-style as alias for pygments-theme, but maybe @mojavelinux should add an opposite alias to asciidoctor-pdf to be consistent with Asciidoctor (core). ;)

@habamax
Copy link
Author

habamax commented Dec 17, 2017

I will be content with any variant that will let me specify rouge theme/style once.

@mojavelinux, what do you think?

@jirutka
Copy link
Owner

jirutka commented Jan 2, 2018

ping @mojavelinux

@jirutka jirutka closed this as completed in 20f0b74 Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants