Share mapped memory to the host when guest is in init phase #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jouni Ukkonen <jouni.ukkonen@unikie.com>
janik-h
requested changes
Jan 25, 2023
|
Wait why would you want to do this? Which pages are you trying to leave as shared? |
|
Besides, I think we go to RUNNING state already when the initial cpu issues PSCI_VERSION, so there shouldn't be any pages this actually leaves open. |
If host blinding is enabled, crosvm/cuttlefish cause crash during init phase. |
|
That said, I don't think this is the right approach. You would need to check what the guest kernel attempts to share exactly and add a patch to the guest kernel to open it up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jouni Ukkonen jouni.ukkonen@unikie.com