Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation file for Dutch texts #296

Closed
CasparTheBridge opened this issue Jul 23, 2024 · 7 comments
Closed

Translation file for Dutch texts #296

CasparTheBridge opened this issue Jul 23, 2024 · 7 comments

Comments

@CasparTheBridge
Copy link

Is your feature request related to a problem? Please describe.
Looks like I can't do a pull request. I've created a Dutch translation for the translation files.

Describe the solution you'd like
Would be nice if I can also translate the texts of the charging entity etc.

Describe alternatives you've considered
Upload it myself as a pull request.

Additional context
None

nl.json

@jonasbkarlsson
Copy link
Owner

Thanks for the translation. You should be able to do a pull request. Others have been able to to that. Do you want to try again?

Also, what did you mean by "translate the texts of the charging entity"? Do mean the name of the entities, such as sensor.ev_smart_charging_charging?

@jonasbkarlsson
Copy link
Owner

jonasbkarlsson commented Aug 1, 2024

Do you want to provide translation for the following?

ENTITY_NAME_CHARGING_SENSOR = "Charging"
ENTITY_NAME_STATUS_SENSOR = "Status"
ENTITY_NAME_ACTIVE_SWITCH = "Smart charging activated"
ENTITY_NAME_APPLY_LIMIT_SWITCH = "Apply price limit"
ENTITY_NAME_CONTINUOUS_SWITCH = "Continuous charging preferred"
ENTITY_NAME_EV_CONNECTED_SWITCH = "EV connected"
ENTITY_NAME_KEEP_ON_SWITCH = "Keep charger on"
ENTITY_NAME_OPPORTUNISTIC_SWITCH = "Opportunistic charging"
ENTITY_NAME_LOW_PRICE_CHARGING_SWITCH = "Low price charging"
ENTITY_NAME_LOW_SOC_CHARGING_SWITCH = "Low SOC charging"
ENTITY_NAME_START_BUTTON = "Manually start charging"
ENTITY_NAME_STOP_BUTTON = "Manually stop charging"
ENTITY_NAME_CONF_PCT_PER_HOUR_NUMBER = "Charging speed"
ENTITY_NAME_CONF_MAX_PRICE_NUMBER = "Electricity price limit"
ENTITY_NAME_CONF_OPPORTUNISTIC_LEVEL_NUMBER = "Opportunistic level"
ENTITY_NAME_CONF_LOW_PRICE_CHARGING_NUMBER = "Low price charging level"
ENTITY_NAME_CONF_LOW_SOC_CHARGING_NUMBER = "Low SOC charging level"
ENTITY_NAME_CONF_MIN_SOC_NUMBER = "Minimum EV SOC"
ENTITY_NAME_CONF_START_HOUR = "Charge start time"
ENTITY_NAME_CONF_READY_HOUR = "Charge completion time"

@jonasbkarlsson
Copy link
Owner

jonasbkarlsson commented Aug 3, 2024

@CasparTheBridge, I have added support for translation in the branch feature.translation. Also adding translation for entity information (names, states, attributes).

Can you provide the Dutch translations for the entity information, see this file? And try to keep the translation as short as possible.

@CasparTheBridge
Copy link
Author

Thank you very much!

I see I tried to do the initial pull request in the wrong way (and I see I now did the pull request in the wrong way not linked it to the feature.translatation. Should I correct this or can you merge these two?

@jonasbkarlsson
Copy link
Owner

Thank you! I copied the first manually, and the second I have now merged into feature.translation.

@hmmbob
Copy link
Contributor

hmmbob commented Aug 12, 2024

This one can be closed now that #308 has been merged, right?

@jonasbkarlsson
Copy link
Owner

Included in v2.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants