Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide ergonomic access to Pro features #18

Open
jonhoo opened this issue Jan 23, 2019 · 7 comments
Open

Provide ergonomic access to Pro features #18

jonhoo opened this issue Jan 23, 2019 · 7 comments

Comments

@jonhoo
Copy link
Owner

jonhoo commented Jan 23, 2019

Faktory now has a Pro edition, and that comes with (at the time of writing) two new API-facing features. Specifically, it adds unique jobs and expiring jobs. It'd be good to have a convenient interface to these without having to set fields in job.custom manually in the right format. These additional convenient methods should probably be under a non-default feature called "pro" so that non-pro users don't see methods they can't use.

@mperham
Copy link

mperham commented Jan 23, 2019

The Faktory Pro OSX binary available with each release can be used to test it live if necessary (or at least prove it works once manually).

@jonhoo
Copy link
Owner Author

jonhoo commented Jan 23, 2019

@mperham In line with contribsys/faktory#180 I would love if the official client libraries did this in their CIs so other clients could copy their approach

@mperham
Copy link

mperham commented Jan 23, 2019

Unfortunately I can't provide the Linux binary necessary for most CI environments.

@jonhoo
Copy link
Owner Author

jonhoo commented Jan 23, 2019

@mperham that's fine -- a macOS-only CI test would be fine. Anything automated helps!

@worst
Copy link

worst commented Jul 10, 2021

@jonhoo are you actively working on this? I wanted to check before I start devoting some cycles to it. Expiring and unique jobs are relatively easy to get going I think.

@jonhoo
Copy link
Owner Author

jonhoo commented Jul 11, 2021

I'm passively maintaining the project, but not actively working on this feature in particular, no. So please do feel free. I'm also looking for maintainers if anyone using Faktory on a regular basis is looking to step up to the plate :)

@rustworthy
Copy link
Collaborator

The JobBuilder PR followed by expiring and unique jobs PR will be the first steps in enabling ergonomic access to Enterprise Faktory features.

API for batch and trackable jobs will be added next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants