Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timed sustain #2

Open
maditnerd opened this issue Jun 17, 2015 · 2 comments
Open

Timed sustain #2

maditnerd opened this issue Jun 17, 2015 · 2 comments

Comments

@maditnerd
Copy link
Contributor

(This is mostly a reminder for me)

I needed some sustain for the piano but if I use sustain=True there was too much sustain.
You can however have more or less sustain by tweaking FADEOUTLENGTH.

@josephernest
Copy link
Owner

In fact sustain = True is modified "live" when we use a Sustain Pedal.
When a Midi Message CC #64 arrives (see here), sustain is modified to True or False :
https://github.com/josephernest/SamplerBox/blob/master/samplerbox.py#L218
If we manually set sustain = True, all the notes will last forever, and this results in too much sustain.

The best way is probably, as you said to tweak FADEOUTLENGTH...

... or maybe later we should add more things in definition.txt, such as %fadeout or %release etc.

@SirPrimalform
Copy link

A per-instrument fade out time in the definition file would be much appreciated. The current global setting means it'll always be wrong for some instruments. Organs and mellotron sounds need almost immediate fade out, but that obviously sounds weird for a natural sounding piano.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants