diff --git a/.github/workflows/linters.yml b/.github/workflows/linters.yml index 78306320..4671d694 100644 --- a/.github/workflows/linters.yml +++ b/.github/workflows/linters.yml @@ -18,6 +18,8 @@ jobs: run: | gem install --no-document rubocop -v '>= 1.0, < 2.0' # https://docs.rubocop.org/en/stable/installation/ [ -f .rubocop.yml ] || wget https://raw.githubusercontent.com/microverseinc/linters-config/master/ror/.rubocop.yml + - name: Rubocop Report + run: rubocop --color stylelint: name: Stylelint runs-on: ubuntu-22.04 @@ -39,4 +41,4 @@ jobs: - uses: actions/checkout@v3 - name: Check node_modules existence run: | - if [ -d "node_modules/" ]; then echo -e "\e[1;31mThe node_modules/ folder was pushed to the repo. Please remove it from the GitHub repository and try again."; echo -e "\e[1;32mYou can set up a .gitignore file with this folder included on it to prevent this from happening in the future." && exit 1; fi + if [ -d "node_modules/" ]; then echo -e "\e[1;31mThe node_modules/ folder was pushed to the repo. Please remove it from the GitHub repository and try again."; echo -e "\e[1;32mYou can set up a .gitignore file with this folder included on it to prevent this from happening in the future." && exit 1; fi \ No newline at end of file diff --git a/.stylelintrc.json b/.stylelintrc.json index 7a1e94b0..5fa8628c 100644 --- a/.stylelintrc.json +++ b/.stylelintrc.json @@ -29,4 +29,4 @@ "csstree/validator": true }, "ignoreFiles": ["build/**", "dist/**", "**/reset*.css", "**/bootstrap*.css"] -} +} \ No newline at end of file diff --git a/Gemfile b/Gemfile index d7bfae4a..120a8fa1 100644 --- a/Gemfile +++ b/Gemfile @@ -78,3 +78,4 @@ gem 'cancancan' gem 'devise', '~> 4.9' gem 'faker', '~> 2.18', require: false gem 'letter_opener', group: :development +gem 'rubocop', '>= 1.0', '< 2.0' \ No newline at end of file diff --git a/Gemfile.lock b/Gemfile.lock index e15bd59a..fac9520c 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -68,6 +68,8 @@ GEM tzinfo (~> 2.0) addressable (2.8.5) public_suffix (>= 2.0.2, < 6.0) + ast (2.4.2) + base64 (0.1.1) bcrypt (3.1.19) bindex (0.8.1) bootsnap (1.16.0) @@ -122,6 +124,8 @@ GEM jbuilder (2.11.5) actionview (>= 5.0.0) activesupport (>= 5.0.0) + json (2.6.3) + language_server-protocol (3.17.0.3) launchy (2.5.2) addressable (~> 2.8) letter_opener (1.8.1) @@ -153,6 +157,10 @@ GEM nokogiri (1.15.3-x64-mingw-ucrt) racc (~> 1.4) orm_adapter (0.5.0) + parallel (1.23.0) + parser (3.2.2.3) + ast (~> 2.4.1) + racc pg (1.5.3-x64-mingw-ucrt) public_suffix (5.0.3) puma (5.6.6) @@ -193,6 +201,7 @@ GEM rake (>= 12.2) thor (~> 1.0) zeitwerk (~> 2.5) + rainbow (3.1.1) rake (13.0.6) regexp_parser (2.8.1) reline (0.3.7) @@ -218,6 +227,21 @@ GEM rspec-mocks (~> 3.12) rspec-support (~> 3.12) rspec-support (3.12.1) + rubocop (1.56.0) + base64 (~> 0.1.1) + json (~> 2.3) + language_server-protocol (>= 3.17.0) + parallel (~> 1.10) + parser (>= 3.2.2.3) + rainbow (>= 2.2.2, < 4.0) + regexp_parser (>= 1.8, < 3.0) + rexml (>= 3.2.5, < 4.0) + rubocop-ast (>= 1.28.1, < 2.0) + ruby-progressbar (~> 1.7) + unicode-display_width (>= 2.4.0, < 3.0) + rubocop-ast (1.29.0) + parser (>= 3.2.1.0) + ruby-progressbar (1.13.0) rubyzip (2.3.2) sass-rails (6.0.0) sassc-rails (~> 2.1, >= 2.1.1) @@ -255,6 +279,7 @@ GEM concurrent-ruby (~> 1.0) tzinfo-data (1.2023.3) tzinfo (>= 1.0.0) + unicode-display_width (2.4.2) warden (1.2.9) rack (>= 2.0.9) web-console (4.2.0) @@ -294,6 +319,7 @@ DEPENDENCIES rails (~> 7.0.6) rails-controller-testing rspec-rails + rubocop (>= 1.0, < 2.0) sass-rails (~> 6.0) selenium-webdriver shoulda-matchers (~> 3.0) diff --git a/app/assets/stylesheets/application.scss b/app/assets/stylesheets/application.scss index 1700b5cd..a8c6cea8 100644 --- a/app/assets/stylesheets/application.scss +++ b/app/assets/stylesheets/application.scss @@ -70,7 +70,6 @@ form { padding: 10px 0; color: $grey; border-bottom: none; - } ::placeholder {