From 31840fb8636c203a9e596c0628b44b2e0061d540 Mon Sep 17 00:00:00 2001
From: jrfnl <jrfnl@users.noreply.github.com>
Date: Sat, 18 Jul 2020 17:00:16 +0200
Subject: [PATCH] WIP | Add new rules to Core ruleset based on Make post

Related:
* `Universal.Namespaces.OneDeclarationPerFile` - upstream Extra #6
* `Universal.Namespaces.DisallowCurlyBraceSyntax` - upstream Extra #4
* `Universal.Namespaces.DisallowDeclarationWithoutName` - upstream Extra #50

* `Universal.UseStatements.NoLeadingBackslash` - upstream Extra #46
* `Universal.UseStatements.LowercaseFunctionConst` - upstream Extra #58

* `Universal.Constants.LowercaseClassResolutionKeyword` - upstream Extra #72

* `Generic.WhiteSpace.IncrementDecrementSpacing` - issue #1511, upstream PHPCS #2172, #2174
* `Universal.Operators.DisallowStandalonePostIncrementDecrement` - upstream Extra #65

* `Universal.Constants.UppercaseMagicConstants` - upstream Extra #64
---
 WordPress-Core/ruleset.xml | 43 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/WordPress-Core/ruleset.xml b/WordPress-Core/ruleset.xml
index e9f604805e..8c9446187b 100644
--- a/WordPress-Core/ruleset.xml
+++ b/WordPress-Core/ruleset.xml
@@ -468,6 +468,49 @@
 	<rule ref="WordPress.PHP.DontExtract"/>
 
 
+	<!--
+	HANDBOOK NEEDS ADJUSTING
+	-->
+	<!-- Covers rule: There should be only one namespace declaration per file. -->
+	<rule ref="Universal.Namespaces.OneDeclarationPerFile"/>
+
+	<!-- Covers rules:
+		 Namespace declaration using the curly brace block syntax are not allowed.
+		 Namespace declarations without name (= explicit global namespace) are not allowed.
+		 (as those can only be created using the curly brace block syntax).
+	-->
+	<rule ref="Universal.Namespaces.DisallowCurlyBraceSyntax"/>
+
+	<!-- Covers rule: Namespace declarations without name (= explicit global namespace) are not allowed. -->
+	<rule ref="Universal.Namespaces.DisallowDeclarationWithoutName"/>
+
+
+	<!-- Covers rule: Names in an import use statement should not start with a leading backslash. -->
+	<rule ref="Universal.UseStatements.NoLeadingBackslash"/>
+
+	<!-- Covers rule: The use, function, const and as keywords should be lowercase.
+		 This is partially already covered via Generic.PHP.LowerCaseKeyword
+	-->
+	<rule ref="Universal.UseStatements.LowercaseFunctionConst"/>
+
+
+
+	<!-- Covers rule: The "::class" keyword for classname resolution must be in lowercase. -->
+	<rule ref="Universal.Constants.LowercaseClassResolutionKeyword"/>
+
+
+	<!-- Covers rule: There should be no space between an increment/decrement operator and the variable it applies to. -->
+	<rule ref="Generic.WhiteSpace.IncrementDecrementSpacing"/>
+
+	<!-- Covers rule: Pre-increment/decrement should be favoured over post-increment/decrement for stand-alone statements. -->
+	<rule ref="Universal.Operators.DisallowStandalonePostIncrementDecrement">
+		<type>warning</type>
+	</rule>
+
+	<!-- Covers rule: The PHP native __...__ magic constants should be in uppercase when used. -->
+	<rule ref="Universal.Constants.UppercaseMagicConstants"/>
+
+
 	<!--
 	#############################################################################
 	Not in the handbook: Generic sniffs.