From c038d22262a45a72993a9286c192dcfcadfac492 Mon Sep 17 00:00:00 2001 From: Dion Wilde <91852142+dion-w@users.noreply.github.com> Date: Wed, 31 Jul 2024 16:19:06 +0200 Subject: [PATCH] replacing rounded faraday constant with exact value in bpx.py (#4290) * updated faraday constant to exact value in bpx.py * Update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com> * Update CHANGELOG.md * Update pybamm/parameters/bpx.py Co-authored-by: Eric G. Kratz * Update CHANGELOG.md Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com> --------- Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com> Co-authored-by: Eric G. Kratz Co-authored-by: Arjun Verma --- pybamm/parameters/bpx.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pybamm/parameters/bpx.py b/pybamm/parameters/bpx.py index 7068a55608..49f8c0792e 100644 --- a/pybamm/parameters/bpx.py +++ b/pybamm/parameters/bpx.py @@ -240,7 +240,7 @@ def _entropic_change(sto, c_s_max, dUdT, constant=False): # (cs-cs_max)) in BPX exchange current is defined j0 = F * k_norm * sqrt((ce/ce0) * # (cs/cs_max) * (1-cs/cs_max)) c_e = pybamm_dict["Initial concentration in electrolyte [mol.m-3]"] - F = 96485 + F = pybamm.constants.F.value def _exchange_current_density(c_e, c_s_surf, c_s_max, T, k_ref, Ea): return (