Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the ML code for: type_compare mutability_compare prim_compare #39

Open
barockobamo opened this issue Sep 24, 2018 · 1 comment
Labels
generator Issues with the ocaml to js generator and ppx extensions jsref Tasks impacting jsref design and codebase.

Comments

@barockobamo
Copy link
Collaborator

From #26 :

clean up the ML code for: type_compare mutability_compare prim_compare;
for prim_compare, we should be able to match on pairs of arguments, with a catch-all

@IgnoredAmbience IgnoredAmbience added generator Issues with the ocaml to js generator and ppx extensions jsref Tasks impacting jsref design and codebase. labels Sep 24, 2018
@IgnoredAmbience
Copy link
Member

Matching on pairs of arguments is currently outside of our ml subset. Make direct comparison of these compare functions with ecma262 text to see how we should implement to be syntactically close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generator Issues with the ocaml to js generator and ppx extensions jsref Tasks impacting jsref design and codebase.
Projects
None yet
Development

No branches or pull requests

2 participants