Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap out Debug.impossible_ with spec_assert_fail (or similar) #52

Open
barockobamo opened this issue Sep 24, 2018 · 1 comment
Open
Labels
jsref Tasks impacting jsref design and codebase.

Comments

@barockobamo
Copy link
Collaborator

From #26 :

jsinterpreter.ml: replace
(fun s m -> Debug.impossible_with_heap_because LOC s m; Result_impossible) s ("[run_object_method] returned a primitive in [object_proto_is_prototype_of_body].")
with (after defining an « impossible » function)
impossible s "[run_object_method] returned a primitive in [object_proto_is_prototype_of_body]."

@IgnoredAmbience
Copy link
Member

IgnoredAmbience commented Sep 24, 2018

This has been partially done in places already, any remaining cases of Debug.impossible in JsInterpreter should be replaced by let%assert or spec_assert or spec_assert_fail, or similar depending on usage.

@IgnoredAmbience IgnoredAmbience changed the title Fix jsinterpreter.ml Swap out Debug.impossible_ with spec_assert_fail (or similar) Sep 24, 2018
@IgnoredAmbience IgnoredAmbience added the jsref Tasks impacting jsref design and codebase. label Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jsref Tasks impacting jsref design and codebase.
Projects
None yet
Development

No branches or pull requests

2 participants