Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Error.cause #85

Closed
rhodgkins opened this issue Nov 25, 2021 · 3 comments
Closed

Support for Error.cause #85

rhodgkins opened this issue Nov 25, 2021 · 3 comments
Labels
duplicate

Comments

@rhodgkins
Copy link

Node 16.9 / V8 9.3 added a cause property to Error.

Can this support be added into this package? Even if it's not running a version that supports the extra Error constructor options, it would be good to attach it to HttpError.cause anyway.
@dougwilson
Copy link
Contributor

Yep, indeed it is being added.

Duplicate of #78 (see #78 (comment))

@rhodgkins
Copy link
Author

Ah apologies, I did have a quick search but didn’t spot that 👍

@dougwilson
Copy link
Contributor

No apologies necessary 😀 it is hard to go though a bunch of issues, so I don't blame anyone. The response is more for project organizing than blaming anyone.

We will also move to stop mixing the errors as well by default and attaching as cause (with an option to keep opd behavior if wanted) though the factory function 😌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dougwilson @rhodgkins