Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scaledgeomean exported but not defined #392

Closed
ericphanson opened this issue Jul 11, 2020 · 1 comment · Fixed by #504
Closed

scaledgeomean exported but not defined #392

ericphanson opened this issue Jul 11, 2020 · 1 comment · Fixed by #504
Labels

Comments

@ericphanson
Copy link
Collaborator

We have a file https://github.com/jump-dev/Convex.jl/blob/38e5fcce49f34c5d54c925ca5adbfb1979948be8/src/atoms/second_order_cone/scaledgeomean.jl that defines the function, but it never gets included and is not tested. I took a brief look at the git history and couldn't find if it was ever included. We can either include it and test it or take it out.

@aravindh-krishnamoorthy

This seems to be a partial solution to #388 but is not exported. Better to unify this with geomean when updating Convex.jl to MOI. So, the best solution is to leave it as it is and remove it when both this and geomean are changed to use MOI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants