Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EXP tests #24

Closed
blegat opened this issue Jul 23, 2020 · 6 comments
Closed

Fix EXP tests #24

blegat opened this issue Jul 23, 2020 · 6 comments

Comments

@blegat
Copy link
Member

blegat commented Jul 23, 2020

The MPB implementation relied on https://github.com/mlubin/ConicNonlinearBridge.jl/ to bridge the exp constraint into nonlinear constraints. We may want to way jump-dev/MathOptInterface.jl#846 and implement an MOI bridge from the exp constraint to a nonlinear one.

@blegat blegat mentioned this issue Jul 23, 2020
4 tasks
@ccoffrin
Copy link
Collaborator

As a fall back, I presume one can specify the EXP constraint in a non-linear form rather than a conic, correct?

@blegat
Copy link
Member Author

blegat commented Jul 23, 2020

Correct, in fact the bridge would reformulate the exp conic constraint into the exact same nlp form.

@mlubin
Copy link
Member

mlubin commented Jul 23, 2020

Why does Pavito accept EXP constraints? It's an MINLP solver, not a MI-conic solver.

@blegat
Copy link
Member Author

blegat commented Jul 24, 2020

It got it from free with the Conic to NLP bridge in MPB. Testing with these did not really test any features of Pavito, it was just additional coverage for Pavito and the Conic to NLP bridges.
By the way, the Pavito support for quadratic constraints can be removed once we have a bridge from quadratic constraints to NLP constraints. I added it as a temporary workaround for consistency with MPB where quad constraints were included in the NLP constraints. It also seemed to be an important use case of Pavito so it deserved a temporary workaround.

@chriscoey
Copy link
Contributor

chriscoey commented Nov 21, 2021

@blegat I think I will close this issue if that's OK - our test coverage is pretty good after #25.

Do we have the bridge from quadratic to NLP constraints in MOI? is it time to remove the temporary workaround for quad constraints? looks like no bridges to NLP

@odow
Copy link
Member

odow commented Nov 22, 2021

Closing because Pavito does not support exponential cones.

@odow odow closed this as completed Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

5 participants