From 003d360410c98b30b3507d357da320f24a152d07 Mon Sep 17 00:00:00 2001
From: Juwan Yoo <vhain6512@gmail.com>
Date: Wed, 8 Mar 2017 19:36:15 -0800
Subject: [PATCH] net: allow missing callback for Socket.connect

Arguments of Socket.prototype.connect should be also normalized,
causing error when called without callback.

Changed Socket.prototype.connect's code same as net.connect and added
test.

Fixes: https://github.com/nodejs/node/issues/11761
PR-URL: https://github.com/nodejs/node/pull/11762
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
---
 lib/net.js                                    | 24 +++++++------------
 .../test-net-socket-connect-without-cb.js     | 20 ++++++++++++++++
 2 files changed, 29 insertions(+), 15 deletions(-)
 create mode 100644 test/parallel/test-net-socket-connect-without-cb.js

diff --git a/lib/net.js b/lib/net.js
index d2dce399880c82..fb9c72cb95240a 100644
--- a/lib/net.js
+++ b/lib/net.js
@@ -920,24 +920,18 @@ function connect(self, address, port, addressType, localAddress, localPort) {
 }
 
 
-Socket.prototype.connect = function(options, cb) {
+Socket.prototype.connect = function() {
+  const args = new Array(arguments.length);
+  for (var i = 0; i < arguments.length; i++)
+    args[i] = arguments[i];
+  // TODO(joyeecheung): use destructuring when V8 is fast enough
+  const normalized = normalizeArgs(args);
+  const options = normalized[0];
+  const cb = normalized[1];
+
   if (this.write !== Socket.prototype.write)
     this.write = Socket.prototype.write;
 
-  if (options === null || typeof options !== 'object') {
-    // Old API:
-    // connect(port[, host][, cb])
-    // connect(path[, cb]);
-    const args = new Array(arguments.length);
-    for (var i = 0; i < arguments.length; i++)
-      args[i] = arguments[i];
-    const normalized = normalizeArgs(args);
-    const normalizedOptions = normalized[0];
-    const normalizedCb = normalized[1];
-    return Socket.prototype.connect.call(this,
-                                         normalizedOptions, normalizedCb);
-  }
-
   if (this.destroyed) {
     this._readableState.reading = false;
     this._readableState.ended = false;
diff --git a/test/parallel/test-net-socket-connect-without-cb.js b/test/parallel/test-net-socket-connect-without-cb.js
new file mode 100644
index 00000000000000..468b29a3a486d7
--- /dev/null
+++ b/test/parallel/test-net-socket-connect-without-cb.js
@@ -0,0 +1,20 @@
+'use strict';
+const common = require('../common');
+
+// This test ensures that socket.connect can be called without callback
+// which is optional.
+
+const net = require('net');
+
+const server = net.createServer(common.mustCall(function(conn) {
+  conn.end();
+  server.close();
+})).listen(0, common.mustCall(function() {
+  const client = new net.Socket();
+
+  client.on('connect', common.mustCall(function() {
+    client.end();
+  }));
+
+  client.connect(server.address());
+}));