Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the History API #307

Closed
rgbkrk opened this issue Aug 17, 2015 · 6 comments · Fixed by #3115
Closed

Use the History API #307

rgbkrk opened this issue Aug 17, 2015 · 6 comments · Fixed by #3115

Comments

@rgbkrk
Copy link
Member

rgbkrk commented Aug 17, 2015

At least for the dashboard/file system browser, it would be a much cleaner ("no flicker") experience if, when clicking through the file system on our dashboard, we used the history API and manipulated the DOM directly. We do use the contents API for the directory listing, so the dashboard is probably one of the easiest spots to use history.pushState and only update the view of the current directory.

history.pushState, history.popState, and history.replaceState are all well supported across browsers now a days (and have been for a while).

/cc @jdfreder

@rgbkrk
Copy link
Member Author

rgbkrk commented Aug 17, 2015

As long as people are comfortable with this ideology, I'd like to start tackling this in a PR.

@minrk
Copy link
Member

minrk commented Aug 17, 2015

I think it's a good idea. I've wanted the dashboard refactor to happen before doing things like this, but since that's been on the horizon for at least two years now, I don't think it makes any sense to wait for it for anything anymore.

@minrk minrk added this to the 5.0 milestone Sep 11, 2015
@ellisonbg
Copy link
Contributor

I think this makes a lot of sense with our existing dashboard.

@minrk minrk modified the milestone: 5.0 Jan 13, 2017
@JamiesHQ
Copy link
Member

Hi there @rgbkrk - is this still an active request? Thanks!

@rgbkrk
Copy link
Member Author

rgbkrk commented Apr 25, 2017

The way I'd implement has sure changed, now that I've worked with several "routers" 😄. It's still worth doing as it helps users with slower connections especially. We already have the APIs in place. Technically nteract has already done exactly this in commuter. It's intention was for public sharing rather than the notebook server though.

@gnestor
Copy link
Contributor

gnestor commented Dec 7, 2017

I submitted a PR because this was a relatively easy thing to do... We'll see other think 👍

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants