Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Run this cell and advance" does not work in combination with getpass / input #7434

Open
skukhtichev opened this issue Aug 1, 2024 · 1 comment

Comments

@skukhtichev
Copy link

Description

Usually "Run this cell and advance" button is executing a cell and then, when finished, sets focus on the next cell. With this, continuously clicking "Run this cell and advance" will run the whole notebook (Like a manual run all) It turned out that when a call uses getpass / input, the cell is executed, but the advance is not working.

There is a popup window displayed which prevents focusing on the next cell:
Screenshot 2024-08-01 at 18 17 28

Notebook before version 7 allowed to submit the cell execution and then focused on the next cell.

Reproduce

  1. Create a new python notebook
  2. add cell with the following code: input('input: ')
  3. add second cell: print('test')
  4. focus on the first cell and click "Run this cell and advance" button
  5. click "Run this cell and advance" button one more time
  6. the pop up window will be displayed and the next cell will not be submitted for execution

Expected behavior

clicking "Run this cell and advance" button after the executing a code cell with the input will submit next cell for execution.

There is an example how it worked in Notebook version before version 7:
Screenshot 2024-08-01 at 18 24 56

Context

  • Operating System and version: MacOS 14.3.1
  • Browser and version: Version 126.0.6478.127 (Official Build) (arm64)
  • Jupyter Notebook version: 7.2.1
Troubleshoot Output
Paste the output from running `jupyter troubleshoot` from the command line here.
You may want to sanitize the paths in the output.
Command Line Output
Paste the output from your command line running `jupyter notebook` here, use `--debug` if possible.
Browser Output
Paste the output from your browser Javascript console here, if applicable.
@skukhtichev skukhtichev added bug status:Needs Triage Applied to issues that need triage labels Aug 1, 2024
@RRosio
Copy link
Collaborator

RRosio commented Aug 6, 2024

This was introduced into JupyterLab in jupyterlab/jupyterlab#8713, and Notebook 7 is based on JupyterLab components. Please review the discussion about this on that PR and why it was added. This fix might need to go into JupyterLab as Notebook 7 is based on that Jupyterlab code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants