Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to read error message due to background color of fonts #417

Closed
hellojinwoo opened this issue Mar 5, 2022 · 7 comments
Closed

Unable to read error message due to background color of fonts #417

hellojinwoo opened this issue Mar 5, 2022 · 7 comments
Labels

Comments

@hellojinwoo
Copy link

hellojinwoo commented Mar 5, 2022

Description

  • It is d to difficult read the error messages due to the yellow background color of fonts in some themes.

    Jupyterlab light theme
    image

  • It is okay to read the error messages but when it comes to darcula theme, it becomes very difficult.

    Darcula theme
    image

Reproduce

  1. Code print(abcde)
  2. You can see the yellow background color behind abcde in the error message (the variable abcde is not defined so an error message would appear)

Expected behavior

  • How can I change the background color of some fonts in error message?

Context

  • Operating System and version: Windows 11
  • JupyterLab-Desktop version: 3.2.9-1
  • Installer:
Troubleshoot Output
Paste the output from running `jupyter troubleshoot` from the terminal inside of JupyterLab-Desktop here.
You may want to sanitize the paths in the output.
Browser Output (required for interface issues after loading)
Paste the output from the DevTools JavaScript console here, if applicable.
Logs (required for issues with loading, server and startup)
Paste the logs from the `main.log` file here (optionally also from `renderer.log`).
@hellojinwoo hellojinwoo added the bug label Mar 5, 2022
@krassowski
Copy link
Member

I believe that this should be reported in the darcula theme repository instead. Which of the jupyter darcula themes do you use? https://github.com/dracula/jupyterlab or https://github.com/telamonian/theme-darcula?

@hellojinwoo
Copy link
Author

hellojinwoo commented Mar 6, 2022

@krassowski Thank you for your reply. I am using @telamonian 's theme-darcula. Currently in the issue tab of the repository, there is no issue regarding the color background of fonts in the error message. Should I raise the issue in that repository instead of here?

@krassowski
Copy link
Member

Should I raise the issue in that repository instead of here?

Yes, please.

@hellojinwoo
Copy link
Author

@krassowski but don't we have ways to change the background color, using the jupyterlab-desktop's setting? Let's say I am using the juplyterlab-desktop's default theme, which is jupyterlab-light, and I want to change the background color from yellow to pink. How can I do that?

@JasonWeill
Copy link

@hellojinwoo Changing the background color would require an extension in JupyterLab. If you would like to see this option added to JupyterLab itself, please open a feature request in JupyterLab.

@hellojinwoo
Copy link
Author

hellojinwoo commented Apr 6, 2022

@jweill-aws I wasn't talking about changing the background color. I was talking about color, highlighting the error code. For example, it is yellow in the screenshot that I uploaded, but I want it to be not yellow but white.

@JasonWeill
Copy link

@hellojinwoo Sorry about the confusion. It is best to open a feature request in JupyterLab concerning the desired change in foreground color.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants