Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No "undo" on Mac in a notebook cell #640

Open
oliviermarti opened this issue Apr 18, 2023 · 16 comments
Open

No "undo" on Mac in a notebook cell #640

oliviermarti opened this issue Apr 18, 2023 · 16 comments
Labels

Comments

@oliviermarti
Copy link

Description

I can not find any key combination that perform an undo in a cell. For any kind of cell : python, markdown or raw.

I've tried crtl-z, cmd-z, ctrl-shift-zand cmd-shift-z. No success. It makes JupyterLab unusable :-(

Context

  • Operating System and version: Mac OSX 13.3.1 Ventura
  • JupyterLab-Desktop version: 3.6.2-1
  • Installer: .dmg

Thank's for your help

@JasonWeill
Copy link

JasonWeill commented Apr 18, 2023

@mbektas Are there any other commands in JupyterLab Desktop that do what @oliviermarti describes?

@JasonWeill
Copy link

@krassowski pointed out that jupyterlab/jupyterlab#10791 provides info about applying "undo" and "redo" to individual cells' contents. Does this address your issue?

@oliviermarti
Copy link
Author

I've found information about this experimentalDisableDocumentWideUndoRedo option in StackOverFlow. I've tried to play with it but it doesn't change anything. It's an option about having an undo/redo local to a cell, or more global. It has no effect when undo/redo is not working at all.

PS : I've found the option in the json settings editor view, but not in the default view with click boxes .. (??)

Olivier

@abulte
Copy link

abulte commented May 13, 2023

I'm not sure this is exactly the same issue, but this is what happens on my Mac installation: CMD+Z and CTRL+Z look binded at higher level (Electron? This is not a standard Mac shortcut except for undo AFAIK). Typically, they will close the current tab when pressed.

I've had success rebinding undo to OPTION+Z (in Settings > Advanced settings editor > Keyboard Shortcuts), as there does not seem to be any other conflicting keybinding. @oliviermarti you might want to try that as a temporary solution.

  • Operating System and version: Mac OSX 13.3.1(a) Ventura
  • JupyterLab-Desktop version: 3.6.3-2
  • Installer: .dmg

@oliviermarti
Copy link
Author

@abulte
I'm a bit puzzled with the advanced syntax editor :-( Could you give me the exact lines you add ?
Thank in advance
Olivier

@abulte
Copy link

abulte commented May 16, 2023

I just click on "Add" on the shortcut I'm interested in, and then input my key combination (eg type OPTION+Z).

Capture d’écran 2023-05-16 à 09 48 44

@mbektas
Copy link
Member

mbektas commented May 17, 2023

@oliviermarti I am not able to reproduce this issue. Cmd + Z works fine for me for undoing text input in cells.

@abulte
Copy link

abulte commented May 17, 2023

@mbektas I can reproduce, maybe a Mac OS version or architecture (Silicon here) issue? I'm on a fresh Mac OS install so there should not be any funny stuff in my config.

  • Operating System and version: Mac OSX 13.3.1(a) Ventura
  • JupyterLab-Desktop version: 3.6.3-2
  • Installer: .dmg
  • Architecture : Silicon M1

@mbektas
Copy link
Member

mbektas commented Jun 7, 2023

I tried it on an Apple silicon as well and still cannot reproduce. Do other shortcuts such as Cmd + A (Select all) work for you?

@oliviermarti
Copy link
Author

Yes. Cmd+A, Cmd+C, Cmd+V, Cmd+X are ok.

Olivier

@abdelhakel
Copy link

Yes. Cmd+A, Cmd+C, Cmd+V, Cmd+X are ok.

Olivier

Did you find a solution to your problem ? I'm experiencing the same behavior on my MacBook Pro (M2)...

@oliviermarti
Copy link
Author

I'm presently using option-Z for cancel. Didn't find any proper solution :-(

Olivier

@mbektas
Copy link
Member

mbektas commented Sep 12, 2023

Could you retry with the latest version v4.0.5-1? There wer some Electron.js updates which might also include a fix for this issue.

@abulte
Copy link

abulte commented Sep 12, 2023

@mbektas still no luck here with this version

@oliviermarti
Copy link
Author

@mbektas still no luck here with this version

Same for me. I've tried to reset to settings to defaults.
Olivier

@abdelhakel
Copy link

Could you retry with the latest version v4.0.5-1? There wer some Electron.js updates which might also include a fix for this issue.

Not working for me.
So, on the same laptop Jupyter Lab "CMD-Z" is working fine". But not with Jupyterlab Desktop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants