Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-commit as part of the build-system seems super heavy #12575

Closed
fcollonval opened this issue May 13, 2022 · 0 comments · Fixed by #12680
Closed

pre-commit as part of the build-system seems super heavy #12575

fcollonval opened this issue May 13, 2022 · 0 comments · Fixed by #12680
Labels
maintenance tag:Build System

Comments

@fcollonval
Copy link
Member

From a downstream perspective, adding pre-commit as part of the build-system seems super heavy, as noted on conda-forge/jupyterlab-feedstock#333

Originally posted by @bollwyvl in #12279 (comment)
@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to new issues that need triage label May 13, 2022
@JasonWeill JasonWeill added tag:Build System and removed status:Needs Triage Applied to new issues that need triage labels May 19, 2022
@JasonWeill JasonWeill mentioned this issue May 19, 2022
Closed
@jtpio jtpio mentioned this issue Jun 8, 2022
Closed
@fcollonval fcollonval mentioned this issue Jun 10, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
maintenance tag:Build System
Projects
None yet
Milestone
No milestone
2 participants
@fcollonval @JasonWeill