Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support user-defined y_doc document type #12711

Closed
trungleduc opened this issue Jun 17, 2022 · 3 comments
Closed

Support user-defined y_doc document type #12711

trungleduc opened this issue Jun 17, 2022 · 3 comments

Comments

@trungleduc
Copy link
Member

Problem

The current y_doc handler of JupyterLab uses the file_type of the document to create the corresponding y_doc document, but JupyterLab and jupyter_server hard-coded the file types to file | notebook | directory so any new file type registered with jupyter_ydoc can not be used.

Proposed Solution

Add an optional parameter to the path property of IDocumentProviderFactory.IOptions to specify the type of y_doc
document.

@trungleduc trungleduc added enhancement status:Needs Triage Applied to new issues that need triage labels Jun 17, 2022
@trungleduc
Copy link
Member Author

cc @hbcarlos @davidbrochart

@trungleduc trungleduc self-assigned this Jun 17, 2022
@davidbrochart
Copy link
Contributor

Thanks @trungleduc, yes that is needed to support collaborative editing for new document types.

@trungleduc
Copy link
Member Author

Fixed by jupyter-server/jupyter_server#895.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants