Rename "File Size" column in file browser to "Size"

[JasonWeill]

Description

It is possible to read file sizes when the file size column in the filebrowser is very narrow, so much so that the word "Size" isn't visible in the column header:

Shorten this column name to "Size" — there is no ambiguity here.

For comparison, "Size" is used as a column header in macOS's Finder:

Context

• Operating System and version: macOS Sonoma 14.6.1
• Browser and version: Firefox ESR 129.0.1
• JupyterLab version: 4.3.0beta1

[ChairBorn]

hey, @JasonWeill, I'm looking to contribute, if it's available, can you assign this?

[asli-nobita]

Hi @JasonWeill I'm completely new to open-source contributions and I think this issue is a good one for me to start with. If available, can I work on this?

[krassowski]

^ https://jupyterlab.readthedocs.io/en/latest/developer/contributing.html#contribute

As for the issue in question, some thoughts:

• the "File Size" column currently does not show the size of the directory; it is fine as it is not a "Directory Size" column, but if we rename it to just "Size" then I think it is a reasonable ask to open a follow-up issue for showing size of the directory (in number of items or space usage)
• we could make it responsive as is the "Last modified"/"Modified" column but ideally we would generalise the logic used for "Last modified" column

[jtpio]

we could make it responsive as is the "Last modified"/"Modified" column but ideally we would generalise the logic used for "Last modified" column

Having the same behavior as the "Last Modified / Modified" column sounds good. Also noting that for Notebook 7 "File Size" is not an issue since the file browser takes the full width, so it could stay that way when there is enough space.

[JasonWeill]

@krassowski I've never seen a file browser that displays a "Directory Size" column; instead, the lack of value in the "Size" column is another cue that a particular row represents something other than a file. We should discuss displaying directories' sizes in another issue.

I agree that making the column title names responsive would be good to have.

[JasonWeill]

@ChairBorn Thank you for your interest! I assigned this issue to you. Please leave a comment here if you have any questions or if you'd like us to review a pull request.

[krassowski]

Does "Folder size" count?

[krassowski]

We should discuss displaying directories' sizes in another issue.

#16743

[JasonWeill]

@krassowski It does, but that was an add-on to Windows XP, not a core feature of Windows Explorer in that era. Still useful.

[ChairBorn]

On it, will get back on that shortly

[ChairBorn]

Hey, @JasonWeill, I changed the file browser column name from "File Size" to "Size" as defined on line 2811 of packages/filebrowser/src/listing.ts. Now, it is also defined in overlay of Browser Menu (packages/filebrowser-extension/src/index.ts) as well as commandList docs. I'm not sure which way you would like it. Let me know

I have created a pull request #16749

[ChairBorn]

Ok, so I almost finished writing a helper function to adjust the text according to the space available and then realized that I can't get the Modified to change to Last Modified... It only changes when the layout for that tab is extremely wide


I'll fix the spacing for both of those.