-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable step up and implement ranking #66
Conversation
Now activators will only look on transitions either from the current context or from the root
): Float { | ||
val current = botContext.dialogContext.currentContext | ||
|
||
val factor = when { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why these magic numbers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just by trial-and-error. We have only three sets of states, so we can define constants for them instead of calculating some penalty at runtime
@@ -0,0 +1,38 @@ | |||
package com.justai.jaicf.model.activation.selection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure this interface and its implementations should be placed to model
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can move it to com.justai.jaicf.activator.selection
, is it okay?
* 2. The current state itself; | ||
* 3. States available from the root of scenario. | ||
*/ | ||
open class ContextRankingActivationSelector : ActivationSelector { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not to use this implementation as default selector instead of ContextFirstActivationSelector
? Looks like it covers the context-first selector cases.
Now only the following transitions are available:
Implemented activation selection with two default implementations:
Closes #38