Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] HTTPExtractor should follow redirects #391

Closed
5 tasks
rhazn opened this issue Jul 13, 2023 · 2 comments
Closed
5 tasks

[FEATURE] HTTPExtractor should follow redirects #391

rhazn opened this issue Jul 13, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request softwarecampus Issues related to the Softwarecampus grant

Comments

@rhazn
Copy link
Contributor

rhazn commented Jul 13, 2023

User Story

  1. As a {user/persona}
  2. I want {that the HTTPExtractor can download files from S3 buckets}
  3. So that {I can use data in S3}

User Acceptance Criteria

  • A new optional property "followRedirects" exists for the HTTPExtractor block, by default it is true
  • if followRedirects is true, HTTPExtractor follows redirects

Examples

Notes

Definitions of Done

  • A PR has been opened and accepted
  • All user acceptance criteria are met
  • All tests are passing
@rhazn rhazn added enhancement New feature or request softwarecampus Issues related to the Softwarecampus grant labels Jul 13, 2023
@rhazn rhazn mentioned this issue Jul 13, 2023
4 tasks
@A-M-A-X
Copy link
Contributor

A-M-A-X commented Jul 17, 2023

I used the follow-redirects npm package in combination with the respective types. The default max. number of redirects is 21. Should I make this property available to the jayvee user or should we stick to the default value? @rhazn

@rhazn
Copy link
Contributor Author

rhazn commented Jul 17, 2023

We can stick with the default value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request softwarecampus Issues related to the Softwarecampus grant
Projects
None yet
Development

No branches or pull requests

2 participants