From 5de8d661a373736a010631adf6c0749924f8df36 Mon Sep 17 00:00:00 2001
From: Martin Kennelly <martin.kennelly@intel.com>
Date: Wed, 28 Apr 2021 14:59:34 +0100
Subject: [PATCH] Fix ticker resource leak

Signed-off-by: Martin Kennelly <martin.kennelly@intel.com>
---
 test/util/netns/netns.go | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/test/util/netns/netns.go b/test/util/netns/netns.go
index bb7b1a819..0c85ec1a3 100644
--- a/test/util/netns/netns.go
+++ b/test/util/netns/netns.go
@@ -67,12 +67,14 @@ func SetPfVfLinkNetNs(pfPciAddr, netNsPath string, pollInterval time.Duration, q
 		errL = append(errL, fmt.Errorf("SetPfVfLinkNetNs(): unable to set physical function '%s' network namespace: '%s'", pfPciAddr,
 			err.Error()))
 	}
+	ticker := time.NewTicker(pollInterval)
+	defer ticker.Stop()
 
 	for {
 		select {
 		case <-quitCh:
 			return
-		case <-time.Tick(pollInterval):
+		case <-ticker.C:
 			if err := setVfNetNs(pfPciAddr, targetNetNs); err != nil {
 				//save errors for returning but continue
 				errL = append(errL, err)