Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sriov-network-operator v1.3.0 released but still shows 1.2.0 in Helm chart #762

Closed
jslouisyou opened this issue Aug 27, 2024 · 5 comments
Closed

Comments

@jslouisyou
Copy link

Hello, sriov-network-operator team.

It seems that sriov-network-operator v1.3.0 was released last month, but still shows v1.2.0 in here.

apiVersion: v2
name: sriov-network-operator-chart
version: 1.2.0
kubeVersion: '>= 1.16.0-0'
appVersion: 1.2.0
description: SR-IOV network operator configures and manages SR-IOV networks in the kubernetes cluster
type: application
keywords:
  - sriov
home: https://github.com/k8snetworkplumbingwg/sriov-network-operator
sources:
  - https://github.com/k8snetworkplumbingwg/sriov-network-operator

I'm not sure if it's fine to use the Helm chart from with v1.3.0 tag.
Could you verify whether it's alright to use this?

Thanks!

@SchSeba
Copy link
Collaborator

SchSeba commented Aug 27, 2024

Hi @adrianchiris I think we need to add the version update to the script right?

@adrianchiris
Copy link
Collaborator

we update image chart in-place before publish. so the chart in the published oci image should contain the correct info.

see:

# patch Chart.yaml in-place

the chart in the proj is for dev purposes.

@adrianchiris
Copy link
Collaborator

let me submit PR to this project to update chart version to something generic like : v0.0.0-dev

@adrianchiris
Copy link
Collaborator

submitted #764

@SchSeba
Copy link
Collaborator

SchSeba commented Aug 27, 2024

great thanks!
closing this one

@SchSeba SchSeba closed this as completed Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants