Skip to content

Latest commit

 

History

History
178 lines (140 loc) · 6.14 KB

CONTRIBUTING.md

File metadata and controls

178 lines (140 loc) · 6.14 KB
Raw

How to contribute

  • Reporting bugs
  • Suggesting features
  • Creating PRs

Welcome all of the contributions!

Setup

Needs your ruby, which is a supported version, and some external tools for development.
Author is using Nix, and put the definition.

$ git clone git@github.com:kachick/ruby-ulid.git
$ cd ./ruby-ulid
$ nix develop
$ dprint --version
$ bundle install || bundle update

Dprint

Using dprint for common formatter except ruby.

$ dprint check
$ dprint fmt
...

Rubocop

Using rubocop as a ruby formatter.

$ bundle exec rubocop
$ bundle exec rubocop --autocorrect
...

Touch the development version with REPL

$ ./bin/console
# Starting up IRB with loading developing ULID library
irb(main):001:0> ULID::VERSION
=> "0.9.0"
# On IRB, you can touch behaviors even if it is undocumented
ulid = ULID.generate #=> ULID(2021-04-27 17:27:22.826 UTC: 01F4A5Y1YAQCYAYCTC7GRMJ9AA)
ls ULID

# constants:
#   ..., Error, ...VERSION, ...
# Module#methods: ...
# Class#methods: ...
# ULID.methods:
#   at                        decode_time  encode  floor                 from_integer  generate  max   min
#   normalize                 normalized?  parse   parse_variant_format  range         sample    scan  try_convert
#   valid_as_variant_format?
# => nil

How to make ideal PRs (Not a mandatory rule, feel free to PR!)

If you try to add/change/fix features, please update and/or confirm core feature's tests are not broken.

$ bundle exec rake test
$ echo $?
0

If you want to run partially tests, test-unit can take some patterns(String/Regexp) with the naming.

❯ bundle exec rake test TESTOPTS="-v -n'/test_.*generate/i'"
Loaded suite /nix/store/d2grc9vz9d3bgl3ncjj7s0nrqi4xz003-ruby-3.2.1/lib/ruby/gems/3.2.0/gems/rake-13.0.6/lib/rake/rake_test_loader
Started
TestULIDClass:
  test_generate:                                                                                        .: (0.000568)
  test_generate_with_invalid_arguments:                                                                 .: (0.001486)
TestULIDMonotonicGenerator:
  test_generate_and_encode_can_be_used_together:                                                        .: (0.001844)
  test_generate_ignores_lower_moment_than_last_is_given:                                                .: (0.000249)
  test_generate_just_bump_1_when_same_moment:                                                           .: (0.000173)
  test_generate_optionally_take_moment_as_milliseconds:                                                 .: (0.001897)
  test_generate_optionally_take_moment_as_time:                                                         .: (0.004004)
  test_generate_raises_overflow_when_called_on_max_entropy:                                             .: (0.000288)
  test_generate_with_negative_moment:                                                                   .: (0.000098)

Finished in 0.011706387 seconds.
------------------------------------------------------------------------------------------------------------------------
9 tests, 503 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
------------------------------------------------------------------------------------------------------------------------
768.81 tests/s, 42968.00 assertions/s

CI includes other heavy tests, signature check, lint, if you want to check them in own machine, below command is the one.

But please don't hesitate to send PRs even if something fail in this command!

$ bundle exec rake # mostly, lightweight
$ bundle exec rake simulate_ci # all, heavy
$ echo $?
0

If you try to improve any performance issue, please add benchmarking and check the result of before and after.

$ bundle exec ruby benchmark/the_added_file.rb
# Showing the results

ADR - Architecture decision record

What is ADR?

Adding dependencies for this gem

  • Keep no runtime dependencies
  • Might be unavoidably needed latest versions of ruby standard libraries from https://github.com/ruby/*
  • Keep clean environment in test group. Do not add gems like active_support into test group # ref: My struggle

Adding ULID instance variables

  • Basically should be reduced. ref: #91, #236
  • When having some objects, they should be frozen. ref: #126

Tasks to drop Ruby 3.2

  • grep RUBY_VERSION guards
  • grep 3.2 and 3.3
  • Update gemspec and TargetRubyVersion in .rubocop.yml

Use profiler

> bundle install || bundle update
❯ bundle exec rake stackprof
rm -rf ./tmp/stackprof-*
bundle exec ruby ./scripts/prof.rb
bundle exec stackprof tmp/stackprof-wall-*.dump --text --limit 5
==================================
  Mode: wall(1000)
  Samples: 445 (0.00% miss rate)
  GC: 50 (11.24%)
==================================
     TOTAL    (pct)     SAMPLES    (pct)     FRAME
        86  (19.3%)          86  (19.3%)     String#tr
        88  (19.8%)          40   (9.0%)     ULID::Utils.encode_base32hex
        38   (8.5%)          38   (8.5%)     (sweeping)
        41   (9.2%)          38   (8.5%)     Time#to_r
        80  (18.0%)          34   (7.6%)     Random::Formatter#random_number
bundle exec stackprof tmp/stackprof-cpu-*.dump --text --limit 5
==================================
  Mode: cpu(1000)
  Samples: 45 (0.00% miss rate)
  GC: 6 (13.33%)
==================================
     TOTAL    (pct)     SAMPLES    (pct)     FRAME
         8  (17.8%)           8  (17.8%)     String#tr
         6  (13.3%)           6  (13.3%)     Random.urandom
         5  (11.1%)           5  (11.1%)     Time#to_r
         4   (8.9%)           4   (8.9%)     Rational#*
        10  (22.2%)           4   (8.9%)     Random::Formatter#random_number

See #213 for further detail