Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jttering of the model or mesh when tracking a NFT marker #30

Open
kalwalt opened this issue Jan 13, 2020 · 6 comments
Open

Jttering of the model or mesh when tracking a NFT marker #30

kalwalt opened this issue Jan 13, 2020 · 6 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers NFT nft markerless technology

Comments

@kalwalt
Copy link
Owner

kalwalt commented Jan 13, 2020

You notice that the model or mesh (sphere) without the @hatsumatsu trick interpolating the tracking matrices is flickering/moving a lot. Why this happens? Because we should apply after the tracking a filter to remove the 'noise' with the arFilterTransMat It was 'planned' to add in the first implementation of NFT in jsartoolkit5 in ARMarkerNFT.c The ARMArkerNFT.c is a modified and improved version of ARWrapper/ARMarkerNFT.c. Probably wasn't added for performances reasons.
We could try to add this function in a future to test ( if are not threaded functions) and/or develop another one with gpu.js ? @nicolocarpignoli @ThorstenBux What do you think?

@kalwalt kalwalt added enhancement New feature or request good first issue Good for newcomers NFT nft markerless technology labels Jan 13, 2020
@kalwalt kalwalt self-assigned this Jan 13, 2020
@kalwalt
Copy link
Owner Author

kalwalt commented Jan 25, 2020

The arFilterTransMat seems that not require threading, I think we can try. Starting from ARMarkerNFT.c i willl try to extract an utility function to apply a filter to the pose matrix. I have no a clear idea if I come to something fruitful, maybe it is only a test.

@kalwalt
Copy link
Owner Author

kalwalt commented Jan 25, 2020

I started to work on this subject in this branch https://github.com/kalwalt/jsartoolkit5/tree/filtering-feature

@kalwalt
Copy link
Owner Author

kalwalt commented Jan 27, 2020

I have a nice update! I will soon make a PR for this, in my opinino is better, but i would like to see what do you think...

@kalwalt
Copy link
Owner Author

kalwalt commented Jan 27, 2020

see PR #36

@evaristoc
Copy link

evaristoc commented May 15, 2020

@kalwalt that is a good one! I have been implementing also my own filters for my projects and they are doing okey, I shouldn't ask them for more actually. However my projects with AR.js NFT are demo only.

What of the things that I haven't been able to find out is if the noise filter parameters would change by the characteristics of the target image?

@juanapp
Copy link

juanapp commented Sep 2, 2020

As far as I see, this hasn't been merged yet. Any plans to do so?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers NFT nft markerless technology
Projects
None yet
Development

No branches or pull requests

3 participants