Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long messages containing '@' aren't converted to 'pasties' #136

Closed
mjtko opened this issue Feb 27, 2013 · 5 comments
Closed

Long messages containing '@' aren't converted to 'pasties' #136

mjtko opened this issue Feb 27, 2013 · 5 comments
Assignees
Labels
Milestone

Comments

@mjtko
Copy link
Contributor

mjtko commented Feb 27, 2013

While long messages are usually converted to pasties so the channel doesn't fill up with large quantities of text, if they contain an @ character, they appear not to be.

eg.

user@host $ lots_of_ouput
output
output
output
output
output
output
output
output
output
output
output

Screen Shot 2013-02-27 at 15 33 08

@fusion94
Copy link
Member

This is a bug with the plugins in general. Currently plugins aren't chained and if more than one is used only the first plugin called is used.

In this scenario the @ plugin is being called and used before the pastie plugin.

@ghost ghost assigned gabceb Feb 27, 2013
@gabceb
Copy link
Member

gabceb commented Feb 27, 2013

On my plate of stuff to do to make our plugins better

@fusion94
Copy link
Member

@gabceb that's why i assigned it to you 😄

@donthorp
Copy link
Member

If we're going to allow rooms to have history, make sure the original message is retained, not just the pastie link. I've lost data before relying on pastie. Probably want to consider a gist option/plugin too.

@mjtko
Copy link
Contributor Author

mjtko commented Feb 27, 2013

The pastie isn't actually a Pastie pastie, it's just called a pastie. :) I'd be inclined to use Gists anyway. 😉

The link actually opens up a plain text activities_controller#show right now, so nothing can be lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants