Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make is setting rpath unconditionally #200

Closed
larsks opened this issue Mar 10, 2018 · 4 comments
Closed

Make is setting rpath unconditionally #200

larsks opened this issue Mar 10, 2018 · 4 comments

Comments

@larsks
Copy link
Contributor

larsks commented Mar 10, 2018

Makefile.am sets cava_LDFLAGS to:

cava_LDFLAGS = -L/usr/local/lib -Wl,-rpath /usr/local/lib

The arguments to -L and -rpath should probably be set based on the configured installation prefix, rather than using /usr/local/lib all the time.

I would additionally suggest that the Makefile should not be setting -rpath in any case.

@karlstav
Copy link
Owner

This has already been considered, please check out #144

@karlstav
Copy link
Owner

hi @larsks, have you checked out the other issues surrounding this? I'll be happy to resolve this, but as you can see I'm not sure how.

@larsks
Copy link
Contributor Author

larsks commented Mar 20, 2018

@karlstav I've taken a look through #144. This comment seems to be the solution: people running on distributions that require custom LDFLAGS can set them in the environment when running ./configure.

@karlstav
Copy link
Owner

can this perhaps be done in the autogen.sh script?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants