Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need more discuss: Formatting tools support vertical alignment #708

Closed
amyXia1994 opened this issue Sep 12, 2023 · 1 comment
Closed

Need more discuss: Formatting tools support vertical alignment #708

amyXia1994 opened this issue Sep 12, 2023 · 1 comment
Labels
help wanted Extra attention is needed question Further information is requested tool Issues or PRs related to kcl tools inlucding format, lint, validation, document tools, etc.

Comments

@amyXia1994
Copy link
Contributor

amyXia1994 commented Sep 12, 2023

Enhancement

parent issue: #627

people like to vertically align their code: https://shkspr.mobi/blog/2014/11/why-i-vertically-align-my-code-and-you-should-too/

But currently kcl fmt tool will eliminate all the blanks that users reserved to align their code. KCL should not format out user reserved blank spaces. And maybe provide an option to format KCL code aligned vertically.

reference

Community Notes

  • Please vote by adding a 👍 reaction to the issue to help us prioritize.
  • If you are interested to work on this issue, please leave a comment.
@amyXia1994
Copy link
Contributor Author

amyXia1994 commented Sep 12, 2023

Currently the kcl code style spec does not allow vertical align, so we should discuss the code style first.

cc @Peefy

@amyXia1994 amyXia1994 changed the title [Enhancement] Formatting tools support vertical alignment [WIP] Need more discuss: Formatting tools support vertical alignment Sep 14, 2023
@Peefy Peefy changed the title [WIP] Need more discuss: Formatting tools support vertical alignment Need more discuss: Formatting tools support vertical alignment Nov 20, 2023
@Peefy Peefy added tool Issues or PRs related to kcl tools inlucding format, lint, validation, document tools, etc. help wanted Extra attention is needed labels Nov 20, 2023
@Peefy Peefy added the question Further information is requested label Jan 28, 2024
@kcl-lang kcl-lang locked and limited conversation to collaborators Mar 1, 2024
@Peefy Peefy converted this issue into discussion #1098 Mar 1, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
help wanted Extra attention is needed question Further information is requested tool Issues or PRs related to kcl tools inlucding format, lint, validation, document tools, etc.
Projects
No open projects
Status: Backlog
Development

No branches or pull requests

2 participants