Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase unit test coverage in pkg/util #3871

Closed
zroubalik opened this issue Nov 16, 2022 · 4 comments · Fixed by #4213
Closed

Increase unit test coverage in pkg/util #3871

zroubalik opened this issue Nov 16, 2022 · 4 comments · Fixed by #4213
Assignees
@joshi95
Labels
good first issue Good for newcomers help wanted Looking for support from community stale-bot-ignore All issues that should not be automatically closed by our stale bot testing

Comments

@zroubalik
Copy link
Member

zroubalik commented Nov 16, 2022 •
edited
Loading

Proposal

https://github.com/kedacore/keda/tree/main/pkg/util

  1. Following files don't have unit test, we should target in having majority of those covered
  • gvkr.go
  • http.go
  • normalize_string.go
  • tls_config.go
  1. We should inspect the rest of the package and increase test coverage if needed

Use-Case

No response

Anything else?

No response
@zroubalik zroubalik added help wanted Looking for support from community good first issue Good for newcomers testing stale-bot-ignore All issues that should not be automatically closed by our stale bot labels Nov 16, 2022
@joshi95
Copy link

joshi95 commented Nov 21, 2022

Hey, I can pick it up.

@JorTurFer
Copy link
Member

Nice @joshi95 ! Thanks a lot ❤️ , I assign this to you

@JorTurFer JorTurFer assigned JorTurFer and joshi95 and unassigned JorTurFer Nov 21, 2022
@rafiramadhana
Copy link

hi, may i know this issue's progress? perhaps i can help with some files that have not been done

@JorTurFer
Copy link
Member

AFAIK @joshi95 is doing it

@dttung2905 dttung2905 mentioned this issue Feb 8, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshi95 joshi95

Labels
good first issue Good for newcomers help wanted Looking for support from community stale-bot-ignore All issues that should not be automatically closed by our stale bot testing
Projects
Roadmap - KEDA Core
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Increase test coverage in pkg/util dttung2905/keda
4 participants
@zroubalik @JorTurFer @rafiramadhana @joshi95